Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement json serialization/deserialization for LSP json messages. Part 1/N. #71141

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

CyrusNajmabadi
Copy link
Member

This PR is just the addition of the types. The next PR (#68990) is the consumption of these types.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner December 7, 2023 03:31
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 7, 2023
Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (pending final decision)

@CyrusNajmabadi
Copy link
Member Author

Moving forward. Speedometer showed no issues.

@CyrusNajmabadi CyrusNajmabadi merged commit bf37495 into dotnet:main Dec 18, 2023
24 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the lspApis3 branch December 18, 2023 18:29
@ghost ghost added this to the Next milestone Dec 18, 2023
// </auto-generated>
//------------------------------------------------------------------------------

namespace Microsoft.CodeAnalysis.LanguageServer {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😕 why are we adding this instead of generating it like all the others?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants